withTranslation() typing fix for defaultProps #1226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced TS errors when I tried to define props interface for a component that was wrapped in
withTranslation()
and haddefaultProps
.The
isHeadless
anddefaultStep
props have been marked in the interface as non-optional because they were needed and always provided indefaultProps
. But TypeScript complained if I didn't pass them in JSX for the component:After changing the
withTranslation()
typings inindex.d.ts
, following this instruction,defaultProps
are handled properly.Checklist
npm run test